Repository navigation
Drop NumPy < 2.0 and Python 3.10 - #1922
Merged
Merged
Conversation
Contributor
Author
|
This is weird. I just realized core tests are not triggering despite having a change to the pyproject.toml and multiple yml files in the workflows. I need to troubleshoot that as well.... |
zm711
marked this pull request as draft
October 18, 2026 17:33
This was referenced Oct 18, 2026
Contributor
Author
|
@h-mayorquin one of the things I was trying to fix in this PR at the same time was trigger core tests. Any clues why core isn't triggering? |
h-mayorquin
reviewed
Nov 3, 2026
zm711
commented
Nov 4, 2026
Contributor
Author
|
This requires #1932 to be merged to fix the deprecation of |
Contributor
|
Should we do the corrections ourselves and finish? I am also waiting on this PR for other fixes. |
Contributor
|
Ok, the requirements are merged. We can move forward with this. |
zm711
marked this pull request as ready for review
November 6, 2026 20:52
h-mayorquin
approved these changes
Nov 7, 2026
h-mayorquin
left a comment
h-mayorquin
left a comment
Contributor
There was a problem hiding this comment.
Thanks for doing this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per our NEP + 1 year policy we will drop NumPy < 2.0 which will also require us to drop Python 3.10 (which is EOL). This PR is built on #1916 (which updates actions) so should be merged after (or in lieu of). May need to iron out some bugs as we are adding in NumPy 2.5 (which we haven't tested yet)