Repository navigation
Console redesign: Broadcasts screens (Nuit claire) - #540
Merged
Merged
Conversation
…oadcasts screens SaveBar takes a save label, a disabled state with its reason, and can leave navigation unblocked. FullDrawer takes a title in its bar. The feed Test buttons explain why they are disabled before the broadcast is saved. A table row can show the hover background while its detail is open.
The Broadcasts screen becomes a list with counted status tabs, a search, KPIs and per-row stats; a full-width detail with the funnel, opens and clicks over time, the A/B test, clicked links and an aside; and a one-screen composer that saves as you type, with a live preview and a send summary. The old card list, the four-step drawer and the send modal are removed.
broadcasts.get answers the broadcast of the requested id.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #540 +/- ##
=======================================
Coverage 88.97% 88.97%
=======================================
Files 377 377
Lines 73836 73836
=======================================
Hits 65692 65692
Misses 5435 5435
Partials 2709 2709
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Clearing every UTM field is now saved, a refused Save changes on a scheduled broadcast shows its reason, Send test leaves a scheduled broadcast's pending edits alone and stops on a draft's refused save, a confirmed close asks once, and a pending J is dropped when the drawer leaves its row.
Send test stops only when the server refuses the draft, a refused send shows the server's reason, and a pending J is dropped whenever its page fails.
…s-screens # Conflicts: # console/src/components/layout/FullDrawer.test.tsx # console/src/i18n/locales/ca.po # console/src/i18n/locales/de.po # console/src/i18n/locales/en.po # console/src/i18n/locales/es.po # console/src/i18n/locales/fr.po # console/src/i18n/locales/it.po # console/src/i18n/locales/ja.po # console/src/i18n/locales/pt-BR.po # console/src/services/api/list.ts
pierre-b
marked this pull request as ready for review
November 12, 2026 18:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec 5 "Newsletters" on the Nuit claire components. Plan:
plans/console-redesign-screens-5-broadcasts-plan.md; the corrections from its review (Opus, xhigh, 12/11) are folded into the plan.What changes
SaveBargetssaveLabel,saveDisabled,saveDisabledReasonandblockNavigation.FullDrawergetsbarTitle.is-hoverrow rule inantd-overrides.css.UpsertBroadcastDrawer,SendOrScheduleModal,BroadcastStats,BroadcastLinkStats,DataFeedSettings, and the old page tests. The cases ofBroadcastsPage.templatesRead.test.tsx(Show the template ID without Templates read on lists, broadcasts, automations and segments #536) now live in the AbTestPanel, aside, detail, cards, compose and page tests.No server change, no table or migration, no environment variable.
Tests
npx vitest runpasses, including the newBroadcastsPage.test.tsx.npx tsc -bandnpx eslint .pass with no errors.npm run buildpasses.broadcasts.spec.ts, rewritten for the new screens, passes 8 of 8 locally against the dev server on port 19173. Console e2e does not run in CI.broadcasts.getnow answers the broadcast of the requested id.protected-pages.spec.ts, the broadcasts case passes.LogsPagefails locally, and that screen is untouched here.Captures at 1440 and 1280 px are in the project files under
captures/fil-5-6/.Review
plans/console-redesign-screens-5-broadcasts-plan.md.501be25. A review of that delta found that Send test refused an incomplete draft, fixed in80b93dc.80b93dcand the merge of dev2e5cb40(head), nothing blocking. Each new test fails with its fix reverted.2e5cb40: the console job (type-check, unit tests, lint, build) and the Go unit tests are green.Known, not handled
ChangeVariationSenderModalrenders its own button.