Repository navigation
Conversation
… and message status helpers
…drawers opened from outside
…eet, page rewritten
… sender The statistics re-read on return to the tab, the window slides when the workspace's day changes, and a period switch neither compares two periods nor labels old figures with the new one. No sender flagged default means none, as on the server. Deleting forgets the cached notification; a failed refresh of recent sends keeps its rows.
…it on an empty list
…onal # Conflicts: # console/src/i18n/locales/ca.po # console/src/i18n/locales/de.po # console/src/i18n/locales/en.po # console/src/i18n/locales/es.po # console/src/i18n/locales/fr.po # console/src/i18n/locales/it.po # console/src/i18n/locales/ja.po # console/src/i18n/locales/pt-BR.po
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #543 +/- ##
==========================================
- Coverage 88.97% 88.96% -0.01%
==========================================
Files 377 377
Lines 73836 73836
==========================================
- Hits 65692 65689 -3
- Misses 5435 5437 +2
- Partials 2709 2710 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
The transactional notifications screen of the console is rebuilt on the shared layout components (PageHeader, Panel, KpiStrip, Pill, FullDrawer, RateBar, KeyValueList, TableToolbar, Mono, MetaLine). Console only: the server parts landed in #524.
List
Sheet (
?notification={id}, loaded bytransactional.get, so a shared link opens the right one)Freshness
Logs: the message log accepts
transactional_notification_idin its URL and filters on it.Note
KpiStripleaves a small space (mb-1) under each KPI label, on every screen that uses it.Known, not treated (non-blocking)
2024) is serialised with quotes by the router in the logs links, and the logs screen reads it as is, so the log comes back empty. The fix belongs to the logs screen.LAST_SENT_DAYS.refetchOnWindowFocuson the statistics queries, nor the last day in the daily series key.Tests
npm testafter merging dev (Console redesign: contacts, lists and segments in one page, with a contact sheet #539): 315 files, 5,112 tests, all green; the KpiStrip commit adds one test, green with its file.npx tsc -b, eslint on the changed files,npm run build: clean.features/transactional.spec.tsandprotected-pages.spec.tsat 75a55ed: 33 passed.LogsPage loads and renders logs contentfails on dev too, unrelated.transactional.spec.tswas already red on dev: the generated ID is cut at 32 characters, and its expectation now says so.Queries
The statistics query
message_historygrouped bytransactional_notification_idovercreated_at, through the analytics schema added in #524. No query or schema change on the server here.Review
Reviewed: c2a59e9. After it: a merge of dev, where only the translation catalogues conflicted (re-extracted, every translation kept, checked by hand), and the one-line
KpiStripspacing, left out of review as asked.