Repository navigation
Main: tolerate bogus LOD chunk lengths in v1.8 meshes - #3780
Merged
Merged
Conversation
Some legacy exporters (e.g. Stunt Rally's) wrote an M_MESH_LOD_LEVEL chunk length that only covered the strategy string. Older Ogre versions parsed the nested chunks positionally and loaded these files, but the chunk size sanity check added since rejects them with "LOD level count exceeds chunk size". The declared length is never used for seeking here, so bound the LOD count by the bytes left in the stream instead. This still rejects a count that cannot fit in the file, but accepts the under-declared lengths. Other mesh versions keep the chunk-based check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some legacy exporters (e.g. Stunt Rally's) wrote an M_MESH_LOD_LEVEL chunk length that only covered the strategy string. Older Ogre versions parsed the nested chunks positionally and loaded these files, but the chunk size sanity check added since rejects them with "LOD level count exceeds chunk size".
The declared length is never used for seeking here, so bound the LOD count by the bytes left in the stream instead. This still rejects a count that cannot fit in the file, but accepts the under-declared lengths. Other mesh versions keep the chunk-based check.