Repository navigation
COMMS-5397 (a) OpenAPI generator wiring for API v3.0 - #7758
Draft
cryptalith wants to merge 5 commits into
Draft
cryptalith wants to merge 5 commits into
cryptalith wants to merge 5 commits into
Conversation
This was referenced Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The first of four stacked drafts for COMMS-5397 (an OpenAPI 3.0.3 description of API v3.0). This one wires the generator; it adds no operation metadata and commits no spec yet.
swagger-maven-plugin-jakarta2.2.55 is configured once in the rootpluginManagementand runs atprocess-classesinorcid-pub-webandorcid-api-web. It writestarget/openapi/{public,member}-v3.0.yaml, so nothing generated is committed in this PR.org.orcid.api.common.openapi. Two classes, used by the generator only:OrcidObjectMapperProcessormakes the generator name properties the wayOrcidJacksonJaxbJsonProviderserialises them, through JAXB annotations. It switches off XML root names, so schema names come from@Schema(name); otherwiserecord.Worksandrecord.summary.Worksoverwrite each other asworks.OrcidOpenApiFilter:/error);; qs=quality factor from media types;/v{version}/identifiersto/v3.0/identifiers;null, and dates are milliseconds since the epoch.openapi/base/{public,member}-v3.0.yamlholdinfoandservers, and are merged in by the plugin.org.orcid.core.model.*get explicit@Schema(name = "RecordSummary…"); their simple names clash with orcid-model's.orcid-model.versionproperty. The pinned orcid-model version becomes a property, so a build can use an unreleased one.Runtime impact
None. The new dependency is
provided, and the plugin brings its own swagger, so nothing new reaches a war. It is declared first inorcid-api-commonbecause orcid-model also puts swagger 2.1.1 (same package names) on the compile classpath. Everything else is annotations and build configuration.How it was checked
Executed test counts:
orcid-api-common: 105 tests, including 9 new ones for the two helpers;orcid-core: 1879;orcid-pub-web: 390;orcid-api-web: 1249.All with 0 failures.
Build against the released orcid-model 4.0.2 succeeds and generates both files. They still show 4.0.2's annotation defects, which COMMS-5397 OpenAPI-ready @Schema annotations for the v3.0 model orcid-model#87 fixes.
Contract tests. With Dev fix switch lang in oauth #87 installed locally, the generated files are validated against a running stack built from this branch, with the real ORCID-Oauth server and a fresh database. They validate a public and a member record read, strictly, with unknown properties rejected.
What follows
openapi/*.yaml, and add conformance tests, lint and a drift check intest_mvn.yml.