Add auto_num_nodes smart attribute - #5699
bstepanovski wants to merge 1 commit into
Conversation
|
IIRC this will depend upon OSC/ood_core#955 being implemented first, otherwise auto_queues won't have enough info to set the min and max dynamically as this ticket suggests. It's a bit confusing though because Philosophically, this should be a 'version of bc_num_nodes which has its min and max set by other auto_ fields', so keeping a single source of truth for the appearance and submission details for each will make sense. However implementing it before the min and max can be set is a bit useless since then it is just another |
| end | ||
|
|
||
| module Attributes | ||
| class AutoNumNodes < Attribute |
There was a problem hiding this comment.
You mention bc_num_nodes in a comment, shouldn't we just subclass here?
Not sure if I follow what you're saying exactly. I mean I get it, but I can't tell if it's a call to action (like to hold this PR) or purely informational. |
Definitely a call to hold the PR, as it seems risky to merge it in an incomplete form like this. I can add an 'on hold' label right now |
|
That makes sense. Happy to hold this until OSC/ood_core#955 gets implemented. I can pick it back up then |
Not sure why. When the ood_core update happens, all the changes will be on auto_queues to set data attributes. Maybe some additional tests against this, but this class and view(s) won't change. Or am I missing something? |
|
Thinking about this more, I think this PR should just add the smart attribute and a test. The PM changes look fine in and of themselves, but I feel like we should replace |
Fixes #5680
Adds an
auto_num_nodessmart attribute for dynamically driven node counts.auto_num_nodesas a number field with the same scheduler submit behavior asbc_num_nodesbc_num_nodesfor static limits so implementers can distinguish dynamic/fixed fields