Add ruby 4.0 to CI - #5805
Open
Bubballoo3 wants to merge 9 commits into
Open
Add ruby 4.0 to CI#5805Bubballoo3 wants to merge 9 commits into
Bubballoo3 wants to merge 9 commits into
Conversation
johrstrom
reviewed
Sep 17, 2026
| gem 'beaker-rspec' | ||
| end | ||
|
|
||
| gem "ostruct", "~> 0.6.3" |
Contributor
There was a problem hiding this comment.
I think we can get rid of the version requirement here - I don't imagine ostruct to really change APIs ever.
Contributor
Author
There was a problem hiding this comment.
sounds good. This was just the default entry from bundle add ostruct
johrstrom
reviewed
Sep 17, 2026
Comment on lines
+40
to
+41
| gem 'i18n-tasks', '~> 1.1' | ||
| gem 'highline', '~> 3.0' |
Contributor
There was a problem hiding this comment.
Given these are development gems, I wonder if we want to specify the version at all?
johrstrom
reviewed
Sep 17, 2026
treydock
reviewed
Sep 17, 2026
treydock
reviewed
Sep 17, 2026
treydock
reviewed
Sep 17, 2026
| - "3.1" # Test versions from Debian 12 | ||
| - "3.2" # Test versions from Amazon Linux 2023 and Ubuntu 24.04 | ||
| - "3.3" # Test versions from RHEL8 & RHEL9 & RHEL10 && Ubuntu 26.04 | ||
| - "3.4" |
Contributor
Author
There was a problem hiding this comment.
I added it when we removed 3.0, but I am not aware of any OS that includes it. Kind of surprised that newer OSs would skip it and go straight to 4.0 though.
Co-authored-by: treydock <tdockendorf@osc.edu>
Co-authored-by: treydock <tdockendorf@osc.edu>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do, and what is the related issue, if applicable?
Adds Ruby 4.0 to the CI matrix, and will fix any issues that arise in testing. I was unable to keep with the pattern of mentioning which OS required which version of ruby, as I am unable to find any that provide > 3.3 by default. If someone knows which OS requires 3.4 or 4.0, I'd be happy to add a comment on it
Fixes #5802
Testing
test helpDocumentation
If this PR is for a new feature or behavior change, please help us kick start the documentation with a blurb.
Documentation blurb hereCode Authorship & Understanding
and I take responsibility for its correctness.
Checklist
Anything else?
Screenshots, context, or anything reviewers should know.