rescue both standarderror and exceptions here - #5827
Merged
Merged
Conversation
rescue both standarderror and exceptions here because currently we only rescue standarderrors when exceptions can happen with bad ruby code in ERB files.
Bubballoo3
reviewed
Sep 22, 2026
| yml = YAML.safe_load(content, aliases: true) || {} | ||
| conf.deep_merge!(yml.deep_symbolize_keys) | ||
| rescue => e | ||
| rescue Exception, StandardError => e |
Contributor
There was a problem hiding this comment.
At https://docs.ruby-lang.org/en/master/Exception.html it states that StandardError is a subclass of exception, so rescuing both may be extraneous. I could be convinced if we think it is clearer, but otherwise just rescuing Exception should be ok
Contributor
Author
There was a problem hiding this comment.
Sure, It's just Exception now.
github-project-automation
Bot
moved this from Awaiting Review
to Merged/Closed
in PR Review Pipeline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do, and what is the related issue, if applicable?
rescue both standarderror and exceptions here because currently we only rescue standarderrors when exceptions can happen with bad ruby code in ERB files.
Testing
test helpDocumentation
NA
Code Authorship & Understanding
and I take responsibility for its correctness.
Checklist
Anything else?
NA