Repository navigation
MAINT: Remove proj from pyproject.toml (proj not on pypi) - #241
Merged
Merged
Conversation
VeckoTheGecko
changed the title
proj from pyproject.tomlproj from pyproject.toml (proj not on pypi)
Member
|
Good point. Should have tried to solve that one the proper way. I'll make a new release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
pyproject.tomlhashttps://github.com/OpenDrift/trajan/blob/main/pyproject.toml#L17-L29
listing
projas a dependency. Howeverprojis not a Python library, hence should not be listed here (and should only be listed in the conda recipe - since its a conda-forge package). Proj on PyPI points to a random unrelated package.PyProj's config is a good example of this.
projlisted in thepyproject.tomlThis change will only take effect next release (I would recommend to just cut a minor release now if convenient)
(PS: I think it would be a good idea to revert conda-forge/trajan-feedstock@2be538c which was how I discovered this problem)