Repository navigation
Conversation
This keeps showing up as automatically deleted, so I'm removing it from the repository. It should not matter since the vs-build directory is supposed to be excluded in the main .gitignore directory anyway.
instead of changing the values of the states when blending the UA and steady solutions, change the derivatives
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
UAMod 5’s vortex source still uses unweighted memory derivatives, producing inconsistent vortex evolution when those states freeze.
1 open issue
What changed in this PR
Improves AeroDyn’s continuous unsteady-aerodynamics calculations for UAMod 4–6, targeting smoother states and effective angles of attack.
Changes:
- Replaces steady-state blending with low-velocity derivative weighting.
- Handles angle wrapping when calculating
alphaE. - Removes Visual Studio build ignore rules.
| File | Description |
|---|---|
vs-build/.gitignore |
Removes local build-artifact ignore rules, unrelated to the numerical changes. |
modules/aerodyn/src/UnsteadyAero.f90 |
Updates derivative weighting, blending helpers, and effective-angle calculations. |
Review effort: Balanced
|
|
||
| ! As relative velocity -> 0, slow (and at zero velocity weight, freeze) the x1:x4 memory states | ||
| ! so they are neigher reset nor driven by ill-conditioned inputs. Weight is 1 for |U| >= UA_u_Blend_max | ||
| dxdt%x(1:4) = real( UA_BlendWeightU(u%U), R8Ki ) * dxdt%x(1:4) |
bjonkman
marked this pull request as draft
October 22, 2026 17:41
Contributor
Author
|
After some more digging with a few other use cases, I'm going to refine this a little more. UA models are awesome. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is NOT ready to be merged.
Feature or improvement description
This PR makes some numerical improvements to the continuous unsteady-aero states:
alphaEto deal with +/-180-degree jumps inalpha_34compared tox1orx2states. This is similar to how the state derivatives already deal with the angle of attack subtraction from x1 and x2 states when calculating their derivatives.These changes have resulted in smoother states and alphaE calculations.
Related issue, if one exists
None
Impacted areas of the software
Unsteady aero models that use the HGM-type continuous states: UAMod 4, 5, & 6
Generative AI usage
Assisted-by: Kiro:claude-opus-5.5
Test results, if applicable
ad_BAR_SineMotion_UA4_DBEMT3test fail. The newer results look smoother than the baseline: