Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #1248 +/- ##
=====================================
Coverage 73.0% 73.0%
=====================================
Files 48 48
Lines 6961 6961
=====================================
Hits 5087 5087
Misses 1874 1874 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔵 Needs a closer look
End-to-end notebook validation remains unresolved because current extraction yields 745 throats versus 744 in the saved outputs, requiring human judgment on whether to regenerate or retain those artifacts.
No open issues 🎉
What changed in this PR
Updates the AI-network tutorial for the current snow2 API and adds focused regression coverage for image generation and network extraction.
Changes:
- Replaces the obsolete
parallelizationargument withparallel_kw=None. - Tags the relevant notebook cells for targeted testing.
- Adds assertions for image dimensions, pore data, and throat connectivity.
- The notebook still contains stale 744-throat output while current extraction produces 745 throats.
This pull request is too complex or risky for automated approval.
| File | Summary |
|---|---|
examples/networks/tutorials/using_diffusive_size_factor_AI_with_snow.ipynb |
Updates the snow2 call and marks the image and extraction cells for regression testing. |
test/unit/test_ai_snow_example.py |
Adds regression coverage for the tutorial’s image generation and extracted network structure. |
Review effort: Lite
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the removed
snow2keyword withparallel_kw=Noneso the AI-network tutorial can extract its network using the current API. Adds a regression test for the tutorial's image and extraction cells.Addresses #1224. All 16 focused tests pass. Extraction and AI inference were also verified during validation.
The final comparison remains blocked by a separate mismatch: 745 current throats versus 744 saved DNS values. Reference data and saved outputs are unchanged; this does not establish end-to-end validation.