Repository navigation
fix(system): refresh disk info and improve caching logic - #551
Merged
Merged
Conversation
# Description This commit updates the disk size and free disk size calculations in the SystemService. The refreshDiskInfo method now accurately retrieves disk information and updates the cache with a timestamp to manage stale data. Additionally, tests have been added to ensure the correct behavior of the disk info caching mechanism. ## Changelog - fix: ensure disk size and free disk size are accurately reported - test: add tests for disk info refresh and caching behavior ## Type of change - Bug fix ### Checklist - [x] I have performed a self-review of my own code - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have run tests that prove my fix is effective or that my feature works - [x] I have added tests to keep coverage above 80%
cjlapao
requested review from
alevlasu,
bineesh-n and
sai-kumar-peddireddy
as code owners
October 30, 2026 09:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates the disk size and free disk size calculations in the SystemService. The refreshDiskInfo method now accurately retrieves disk information and updates the cache with a timestamp to manage stale data. Additionally, tests have been added to ensure the correct behavior of the disk info caching mechanism.
Description
Type of change
Checklist