Repository navigation
fix(sandbox): skip HTMLFencedFrameElement to avoid FencedFrame deprecation warning - #788
Merged
gioboa merged 2 commits intoOct 14, 2026
Merged
Conversation
…ation warning readMainInterfaces() creates one element per HTML*Element constructor on window to read its interface. For HTMLFencedFrameElement this creates a <fencedframe> in the sandbox iframe, which Chrome reports as a "FencedFrame" deprecation issue and Lighthouse penalizes under "Uses deprecated APIs". Add it to DEPRECATED_WINDOW_PROPERTIES, following QwikDev#697.
🦋 Changeset detectedLatest commit: fb49fa0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
gioboa
force-pushed
the
fix/fencedframe-deprecation-warning
branch
from
October 14, 2026 08:54
d9e6f84 to
fb49fa0
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description
Follow-up to #697 (#693, #694), same cause and same fix.
readMainInterfaces()creates one element perHTML*Elementconstructor onwindowto read its interface. In Chrome this includesHTMLFencedFrameElement, so a<fencedframe>is created insidepartytown-sandbox-sw.html. Chrome reports this as aFencedFramedeprecation issue, and Lighthouse lists it under "Uses deprecated APIs", which lowers the Best Practices score of every page using Partytown 1.0.0.This adds
HTMLFencedFrameElementtoDEPRECATED_WINDOW_PROPERTIES, so it is skipped like the Privacy Sandbox properties from #697.Verified in Chrome 155 (DevTools issues read via CDP
Audits.issueAdded, the same data the Issues panel and Lighthouse's deprecations audit use) ontests/platform/document-prod:FencedFramedeprecation issue, source/~partytown/partytown-sandbox-sw.htmlTrade-off: scripts in the worker now get a generic
HTMLElementfor<fencedframe>instead ofHTMLFencedFrameElement, so fenced-frame-specific members likeconfigare not available on the proxy ('HTMLFencedFrameElement' in windowstill returnstrue). In practice this only affects Privacy Sandbox ad scripts, and Chrome already marks the API as deprecated.Use cases and why
FencedFrameentry under Lighthouse "Uses deprecated APIs" / DevTools Issues.Checklist: