Repository navigation
fix: keep preserveBehavior objects on main thread fallback - #790
Merged
gioboa merged 2 commits intoOct 14, 2026
Merged
Conversation
馃 Changeset detectedLatest commit: 5893d66 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ArmenMesropyanOptimax
marked this pull request as ready for review
October 14, 2026 08:44
gioboa
approved these changes
Oct 14, 2026
gioboa
left a comment
gioboa
left a comment
Member
There was a problem hiding this comment.
Thanks @ArmenMesropyanOptimax nice fix 馃憦
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #789
The main thread fallback deleted the top-level global of every
forwardentry, includingdataLayerwhendataLayer.pushis forwarded withpreserveBehavior: true, so everything pushed before the fallback was lost. It now keeps objects that have a nested property forwarded withpreserveBehavior. Top-level stubs likefbqare still removed so their scripts can set them up again.Added a unit test, and the
fallbacke2e page now forwardsdataLayer.pushwithpreserveBehaviorand checks the data survives.