Repository navigation
Fix web service in docker setup - #46
Merged
Merged
Conversation
The web service bind-mounts ./web over the image, which hides the composer-installed vendor directory. Loading vendor/autoload.php then fails. Add an anonymous volume for vendor so the image's dependencies remain in place.
Collaborator
|
Thank you, that's an artifact from my own local testing setup leaking in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
webservice bind-mounts./webto/var/www/reon/web. That mount shadows thevendor/directory that the image builds withcomposer install, so at runtimevendor/autoload.phpis missing. The website and CLI scripts such asscripts/add_user.phpfail with a fatal "Failed to open vendor/autoload.php".Change
Adds an anonymous volume for
/var/www/reon/web/vendoron thewebservice so the image's installed dependencies are preserved on top of the bind mount. This is the standard pattern for bind-mounting source over a directory that also contains build output.Testing
With this change the site loads and
add_user.phpruns on a freshdocker compose up, with no manualcomposer installon the host.