feat: file log sink and Compose worker log collection - #44
Merged
Merged
Conversation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Finish remaining TASK 1 LOGS: optional file tee of stderr JSONL, and host-side Compose collection so pipeline runs can join worker logs.
Verify still exits 0 if a log sink fails. Host CLI and
cache-sweephonorAIBOM_RUN_IDwhen set. Compose workers use an explicitjson-filedriver; collect withdocker compose logs --no-log-prefix worker.Fixes #42
Two commits: file sink first, then collect /
AIBOM_RUN_ID.Test plan
test_cli_log_file_tee_does_not_change_stdout(file JSONL == stderr; stdout stillVerificationResult)test_cli_honors_aibom_run_id_on_every_line(and sweep equivalent)test_worker_uses_json_file_logging_driver(YAML pin; no live Docker in CI)uv run ruff check ./uv run ruff format --check ./uv run ty check/uv run pytest -m "not network"(175 passed)uv run pytest -m network(2 passed)AIBOM_LOG_FILE/AIBOM_RUN_ID; collect withdocker compose logs --no-log-prefix workerOut of scope / follow-ups
pythonvspython3default