Repository navigation
fix: a11y in search-results page - #1206
Merged
Merged
Conversation
giuliaghisini
changed the title
giuliaghisini
requested changes
Oct 22, 2026
| </Row> | ||
| <Skiplink tag="div"> | ||
| <SkiplinkItem href="#search-results-region" tag="a"> | ||
| <SkiplinkItem href={`#$"search-results"`} tag="a"> |
Member
There was a problem hiding this comment.
questo non credo che funzioni scritto così.. come risulta il markup ?
Member
There was a problem hiding this comment.
anche l'id "search-results-region" andava bene, non era necessario cambiarlo. Tornerei indietro e manterrei quel nome perchè una modifica di questo tipo potrebbe essere breaking per chi ha fatto personalizzazioni nel tema su quel selettore
… into US78813-accessibility-fix-search-page
giuliaghisini
approved these changes
Oct 28, 2026
Comment on lines
+3979
to
+3985
| msgid "search_live_input_description" | ||
| msgstr "" | ||
|
|
||
| #: components/ItaliaTheme/Search/Search | ||
| # defaultMessage: {start}-{end} di {total} risultati | ||
| msgid "search_results_range" | ||
| msgstr "" |
Member
There was a problem hiding this comment.
da mettere le traduzioni in questa lingua
Comment on lines
+3962
to
+3971
| #: components/ItaliaTheme/Search/Search | ||
| # defaultMessage: I risultati della ricerca verranno aggiornati in base al testo inserito nel campo di ricerca e ai filtri selezionati | ||
| msgid "search_live_input_description" | ||
| msgstr "" | ||
|
|
||
| #: components/ItaliaTheme/Search/Search | ||
| # defaultMessage: {start}-{end} di {total} risultati | ||
| msgid "search_results_range" | ||
| msgstr "" | ||
|
|
Member
There was a problem hiding this comment.
da mettere le traduzioni in questa lingua
Comment on lines
+3971
to
+3980
| #: components/ItaliaTheme/Search/Search | ||
| # defaultMessage: I risultati della ricerca verranno aggiornati in base al testo inserito nel campo di ricerca e ai filtri selezionati | ||
| msgid "search_live_input_description" | ||
| msgstr "" | ||
|
|
||
| #: components/ItaliaTheme/Search/Search | ||
| # defaultMessage: {start}-{end} di {total} risultati | ||
| msgid "search_results_range" | ||
| msgstr "" | ||
|
|
Member
There was a problem hiding this comment.
da mettere le traduzioni in questa lingua
Comment on lines
+3979
to
+3988
| #: components/ItaliaTheme/Search/Search | ||
| # defaultMessage: I risultati della ricerca verranno aggiornati in base al testo inserito nel campo di ricerca e ai filtri selezionati | ||
| msgid "search_live_input_description" | ||
| msgstr "" | ||
|
|
||
| #: components/ItaliaTheme/Search/Search | ||
| # defaultMessage: {start}-{end} di {total} risultati | ||
| msgid "search_results_range" | ||
| msgstr "" | ||
|
|
Member
There was a problem hiding this comment.
da mettere le traduzioni in questa lingua
giuliaghisini
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://redturtle.tpondemand.com/restui/board.aspx?#page=profile&appConfig=eyJhY2lkIjoiM0YwMDA1MEY3Mzg3NjUxOEU4QTcxN0NGODgzMThEQUEifQ==&boardPopup=userstory/78102/silent
fixed hierarchy title for filters and results