Repository navigation
feat: set lang and dir on <html> from the content language - #1213
Open
giulio-red-turtle wants to merge 1 commit into
Open
giulio-red-turtle wants to merge 1 commit into
giulio-red-turtle wants to merge 1 commit into
Conversation
Single-language sites often host a few pages in other languages (Arabic, Urdu, Chinese...). The LanguageSelector forced the default language on <html>, hiding the content language for every content type, and dir was never set (the SSR markup also dropped it). - AppExtras/HtmlLangDir (registered in config/italiaConfig.js) sets lang/dir from the content language; the site language on CMS UI routes and when the content in the store belongs to another path - helpers/contentLanguage: language/direction helpers, rtlLanguages setting, unit tests (also for HtmlLangDir) - LanguageSelector no longer forces the default language - Html renders dir in SSR; #toolbar and #sidebar keep the site lang/dir - Header, Breadcrumbs, SkipLinks, Footer, ContactsBlock, SubsiteFooter, SearchModal, ScrollToTop and the cookie banner keep the site lang/dir, so only the content is rtl - theme: text-align, .text-start/.text-end and list indent use logical values (same output in ltr), callout border and accordion/gallery text follow the direction, the CMS toolbar stays on the left on rtl pages - RELEASE.md entry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Single-language sites often host a few pages in other languages (Arabic, Urdu, Chinese...). The LanguageSelector forced the default language on , hiding the content language for every content type, and dir was never set (the SSR markup also dropped it).