Repository navigation
Us78104 fix menubar a11y - #1214
Open
ilariamassa96 wants to merge 5 commits into
Open
ilariamassa96 wants to merge 5 commits into
ilariamassa96 wants to merge 5 commits into
Conversation
giuliaghisini
requested changes
Oct 28, 2026
| navbar | ||
| aria-label={intl.formatMessage(messages.mainMenu)} | ||
| > | ||
| <Nav data-element="main-navigation" navbar> |
Member
There was a problem hiding this comment.
perchè hai rimosso aria-label?
Author
There was a problem hiding this comment.
perchè già presente qua <HeaderContent
expand="lg"
megamenu
id="navigation"
aria-label={intl.formatMessage(messages.mainMenu)}
mi sembrava ripetitivo però lo rimetto
… into us78104-fix-menubar-a11y
giuliaghisini
requested changes
Oct 29, 2026
Comment on lines
-183
to
-197
| <div className="close-div" style={closeButtonStyle}> | ||
| <button | ||
| className="btn close-menu" | ||
| type="button" | ||
| title={intl.formatMessage(messages.CloseMenu)} | ||
| onClick={() => setCollapseOpen(!collapseOpen)} | ||
| > | ||
| <Icon | ||
| color="white" | ||
| icon="it-close-big" | ||
| padding={false} | ||
| title={intl.formatMessage(messages.CloseMenu)} | ||
| /> | ||
| </button> | ||
| </div> |
Member
There was a problem hiding this comment.
questo direi che deve rimanere perchè dovrebbe essere quello di chiusura del menu quando sei su mobile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://redturtle.tpondemand.com/RestUI/Board.aspx#page=profile&appConfig=eyJhY2lkIjoiM0YwMDA1MEY3Mzg3NjUxOEU4QTcxN0NGODgzMThEQUEifQ==&boardPopup=userstory/78104/silent