Skip to content

[Improve] Make setup conversational and agent-led - #2539

Merged
brunobergher merged 24 commits into
developfrom
improve/setup-integration-history-2rv9qvia3cjxq
Sep 14, 2026
Merged

brunobergher merged 24 commits into
developfrom
improve/setup-integration-history-2rv9qvia3cjxq

Conversation

@roomote-roomote

@roomote-roomote roomote-roomote Bot commented Sep 11, 2026 •

Copy link
Copy Markdown
Contributor

​Created by Roomote. Follow up by mentioning @roomote-roomote, in the web UI, or in Slack.

What changed

  • Make first-admin setup conversational and agent-led while keeping setup actions in trusted UI cards.
  • Offer optional integrations after source control is connected or declined, retain the Asked about integrations receipt, and preserve source-control and starter-work skip decisions across reloads.
  • Suppress repository starter work and automation offers when no repositories are synchronized, and require a sandbox only when selected coding work needs one.
  • Let the reconciled starter_selection turn exclusively own selected starter-task launches so a ready sandbox cannot cause the capability-response turn to launch the same work again.
  • Preserve upstream Session-secret and Session-goal behavior while resolving the branch against current develop.

Why this change was made

Setup should adapt to what an administrator has already provided without coercive gates or repeated questions. Starter work also needs one durable launch owner so each selected task starts exactly once when compute is ready.

Impact

Administrators can connect or skip source control and integrations, start their own work, or select starter tasks without setup reopening skipped choices. When starter tasks are selected, setup waits for a usable sandbox and launches each selected task once; launch attempts can still complete setup even when an individual launch fails.

@roomote-community

roomote-community Bot commented Sep 11, 2026 •

Copy link
Copy Markdown
Contributor

No new code issues found. See task

  • Empty starter-task skips are preserved through state normalization and reconciliation (packages/types/src/setup-new.ts).
  • Selecting starter work with a ready sandbox launches each selected task once (apps/web/src/trpc/commands/fast-sessions/index.ts:979).
  • Capability offers require each requested integration's effective status to be connected (apps/web/src/app/(sandbox)/sessions/[sessionId]/CapabilityOfferCard.tsx:44).
  • Embedded integration setup reconnects needs_connection integrations instead of treating deployment enablement as authentication (apps/web/src/components/settings/Integrations.tsx:2595).

Reviewed bc7fc4b

@roomote-roomote
roomote-roomote Bot marked this pull request as ready for review September 11, 2026 18:12
Comment thread apps/web/src/trpc/commands/setup/setup-session.ts
@roomote-roomote

roomote-roomote Bot commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor Author

Fixed the duplicate starter-work launch and resolved the branch against current develop in 6987241. Reconciliation now exclusively owns selected starter launches, and regression coverage confirms two selected tasks launch exactly twice across the reconciliation and response paths. Existing integration onboarding, the Asked about integrations plug receipt, and durable skip behavior remain intact. Focused setup tests, cloud-agent tests, package typechecks/lint, and the full pre-push gate pass.

@roomote-roomote roomote-roomote Bot changed the title [Improve] Clarify setup integration history [Improve] Let admins continue setup with their own task Sep 14, 2026
…y-2rv9qvia3cjxq' into improve/setup-integration-history-2rv9qvia3cjxq

# Conflicts:
#	apps/web/src/trpc/commands/setup/setup-session.test.ts
#	packages/types/src/setup-new.test.ts
#	packages/types/src/setup-new.ts
@roomote-roomote roomote-roomote Bot changed the title [Improve] Let admins continue setup with their own task [Improve] Make setup conversational and agent-led Sep 14, 2026
Comment thread apps/web/src/trpc/commands/fast-sessions/index.ts
Comment thread apps/web/src/components/settings/Integrations.tsx Outdated
@brunobergher
brunobergher merged commit 6a96412 into develop Sep 14, 2026
19 checks passed
@brunobergher
brunobergher deleted the improve/setup-integration-history-2rv9qvia3cjxq branch September 14, 2026 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants