Skip to content

[Improve] Keep Recent sessions from reshuffling while browsing - #2545

Closed
stea9499 wants to merge 3 commits into
RooCodeInc:developfrom
stea9499:improve/sticky-recent-session-order
Closed

stea9499 wants to merge 3 commits into
RooCodeInc:developfrom
stea9499:improve/sticky-recent-session-order

Conversation

@stea9499

@stea9499 stea9499 commented Sep 11, 2026 •

Copy link
Copy Markdown
Contributor

Why this PR exists

  • I am a maintainer / this is internal Roomote work

What changed

Recent sessions no longer reshuffle while you click through existing items. The sidebar keeps the list it loaded until the next full page load.

A reload still sorts by last real activity in the session (a message, an agent turn, and so on). Opening an older session just to view it does not count, so that row stays where it was.

Also stops incomplete setup from sending an explicit session click back to the setup session (usually the first row).

How it was tested

  • SideNav client tests still pass for recent-session rendering and active-row highlighting.
  • Manual: click through older Recent sessions and confirm the list stays put and the clicked session opens. Reload and confirm a viewed-only session does not jump to the top.

Screen recordings

browsing_recent_sessions.mov

Checklist

  • The PR title follows the repo convention
  • This PR is small and scoped to one change
  • pnpm lint and pnpm check-types pass locally
  • I added tests or included a clear manual validation note above
  • I removed secrets, tokens, private keys, and customer data from code, logs, and screenshots
  • If this change should appear in the changelog, I ran pnpm changeset

Visits still update stored recency, but the visible list stays put until reload or a new session appears.

Co-authored-by: Cursor <cursoragent@cursor.com>
@roomote-community

roomote-community Bot commented Sep 11, 2026 •

Copy link
Copy Markdown
Contributor

No code issues found. See task

  • apps/web/src/app/(sandbox)/SandboxShell.tsx:81 Setup gating is briefly disabled while the setup-status query loads.

Reviewed acdefdc

Freeze the sidebar query until reload, and stop setup from sending an explicit session click back to the first row.

Co-authored-by: Cursor <cursoragent@cursor.com>
Comment thread apps/web/src/app/(sandbox)/SandboxShell.tsx Outdated
The session-click guard already stops the bounce; treat missing setup status as incomplete so gated nav does not flash enabled.

Co-authored-by: Cursor <cursoragent@cursor.com>
@stea9499
stea9499 marked this pull request as ready for review September 11, 2026 19:33
@mrubens

mrubens commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

I think this was just fixed in #2532, but please reopen if not!

@mrubens mrubens closed this Sep 11, 2026
@stea9499

stea9499 commented Sep 22, 2026 via email

Copy link
Copy Markdown
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants