Repository navigation
[Fix] Source control setup buttons are indistinguishable by provider - #3152
Merged
roomote-roomote[bot] merged 1 commit intoSep 23, 2026
Merged
Conversation
Contributor
roomote-roomote
Bot
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
September 23, 2026 05:47
daniel-lxs
approved these changes
Sep 23, 2026
roomote-roomote
Bot
deleted the
fix/source-control-setup-names-2bjtmb4xjdlkp
branch
September 23, 2026 20:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Each unconfigured source-control provider now has a distinct setup button name for assistive technology: “Set it up for GitHub”, “Set it up for GitLab”, “Set it up for Gitea”, “Set it up for Azure DevOps”, or “Set it up for Bitbucket Cloud”. The visible “Set it up” copy and existing setup interaction remain intact. Focused coverage checks all five names and the GitHub setup-form expansion.
Why this change was made
The authenticated Source Control Settings page previously exposed five indistinguishable “Set it up” buttons, making the intended provider ambiguous in assistive-technology navigation. Using the existing provider title keeps the change local to the shared provider block.
Impact
Screen-reader users can identify the provider before activating its setup action; the appearance and normal provider setup flow are unchanged. This is independent of #2400, which changes Session-level optional source-control connection and also touches the component; a rebase may be needed when either branch lands. The GitHub organization visibility work in #3044 is already merged and is not part of this change.
The focused web suite passed (22 tests), web package TypeScript, targeted ESLint/Oxlint/format checks, and the normal push hooks passed. On the real authenticated local settings page, the accessibility tree listed five distinct button names at desktop and mobile sizes; keyboard Enter on GitHub opened its setup form. Screenshots show the unchanged visible copy and layout and the expanded form, but cannot independently prove accessible names or keyboard input. No provider credentials were entered.
Screenshots
Before — desktop provider cards:
After — desktop provider cards:
Before — mobile provider cards:
After — mobile provider cards:
GitHub setup after keyboard activation — desktop and mobile: