Skip to content

[Fix] Source control setup buttons are indistinguishable by provider - #3152

Merged
roomote-roomote[bot] merged 1 commit into
developfrom
fix/source-control-setup-names-2bjtmb4xjdlkp
Sep 23, 2026
Merged

roomote-roomote[bot] merged 1 commit into
developfrom
fix/source-control-setup-names-2bjtmb4xjdlkp

Conversation

@roomote-roomote

Copy link
Copy Markdown
Contributor

​Opened on behalf of @daniel-lxs. Follow up by mentioning @roomote-roomote, in the web UI, or in Telegram.

What changed

Each unconfigured source-control provider now has a distinct setup button name for assistive technology: “Set it up for GitHub”, “Set it up for GitLab”, “Set it up for Gitea”, “Set it up for Azure DevOps”, or “Set it up for Bitbucket Cloud”. The visible “Set it up” copy and existing setup interaction remain intact. Focused coverage checks all five names and the GitHub setup-form expansion.

Why this change was made

The authenticated Source Control Settings page previously exposed five indistinguishable “Set it up” buttons, making the intended provider ambiguous in assistive-technology navigation. Using the existing provider title keeps the change local to the shared provider block.

Impact

Screen-reader users can identify the provider before activating its setup action; the appearance and normal provider setup flow are unchanged. This is independent of #2400, which changes Session-level optional source-control connection and also touches the component; a rebase may be needed when either branch lands. The GitHub organization visibility work in #3044 is already merged and is not part of this change.

The focused web suite passed (22 tests), web package TypeScript, targeted ESLint/Oxlint/format checks, and the normal push hooks passed. On the real authenticated local settings page, the accessibility tree listed five distinct button names at desktop and mobile sizes; keyboard Enter on GitHub opened its setup form. Screenshots show the unchanged visible copy and layout and the expanded form, but cannot independently prove accessible names or keyboard input. No provider credentials were entered.

Screenshots

Before — desktop provider cards:

Source Control Settings before on desktop

After — desktop provider cards:

Source Control Settings after on desktop

Before — mobile provider cards:

Source Control Settings before on mobile

After — mobile provider cards:

Source Control Settings after on mobile

GitHub setup after keyboard activation — desktop and mobile:

Expanded GitHub App setup on desktop

Expanded GitHub App setup on mobile

@roomote-community

roomote-community Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

No code issues found. See task

Reviewed d568c06

@roomote-roomote
roomote-roomote Bot marked this pull request as ready for review September 23, 2026 05:47
@roomote-roomote
roomote-roomote Bot merged commit 3617d87 into develop Sep 23, 2026
17 checks passed
@roomote-roomote
roomote-roomote Bot deleted the fix/source-control-setup-names-2bjtmb4xjdlkp branch September 23, 2026 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant