Skip to content

Handle concurrent device discovery and incomplete stream info - #351

Open
diogormendes wants to merge 3 commits into
SecKatie:mainfrom
diogormendes:fix/stream-info-missing-power
Open

diogormendes wants to merge 3 commits into
SecKatie:mainfrom
diogormendes:fix/stream-info-missing-power

Conversation

@diogormendes

Copy link
Copy Markdown

Summary

  • coalesce concurrent device-list requests behind a shared lock while preserving the existing cache
  • add an explicit force-refresh path for periodic device parameter updates
  • accept stream-info responses that omit iot-device::iot-power when the camera is online
  • avoid including raw API responses in exceptions, preventing tokens and device details from leaking into logs
  • add regression coverage for stream responses without the power property

Validation

  • python3.14 -m compileall -q src tests
  • git diff --check
  • regression test added in tests/test_camera_service.py

pytest could not be run in the local environment because the test dependencies are not installed and uv failed while creating its environment due to a macOS runtime issue.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants