Repository navigation
A3: Dated event banner - #2893
Open
AutomatedTester wants to merge 1 commit into
Open
AutomatedTester wants to merge 1 commit into
AutomatedTester wants to merge 1 commit into
Conversation
✅ Deploy Preview for selenium-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
Author
|
Superseded: the Phase 1 items are being regrouped into one PR per workstream to make the layout easier to review as a whole. This branch's commit is carried over unchanged. Generated by Claude Code |
20 tasks
Member
Author
|
Reopened. Part of the selenium.dev modernisation set; see #2912 for the full list and suggested review order. Generated by Claude Code |
AutomatedTester
marked this pull request as ready for review
October 14, 2026 14:48
Member
|
good change.. thanks David. @AutomatedTester |
diemol
previously approved these changes
Oct 20, 2026
Member
|
@AutomatedTester can you please resolve the conflicts? |
The announcement banner was hard-coded text in the partial and toggled by two booleans (banner_flag, announcement_banner) that someone had to remember to switch off after an event. Replace them with [params.announcement] in hugo.toml carrying text, url, link_text, start and end (ISO dates). A new announcement-active.html partial returns true only when the build date falls within [start, end] inclusive; the navbar and the blocks/section shortcode (which adds the top margin when no banner is shown) both use it. The banner partial now renders the configured text and link instead of hard-coded copy. The params are left in place with an end date in the past so nothing is shown, with a comment explaining how to announce the next event.
Member
Author
|
Rebased onto trunk. The conflict was with #2916 (the aria-pressed fix on the banner link); the templated link now omits that attribute too. Generated by Claude Code |
AutomatedTester
force-pushed
the
site/a3-event-banner
branch
from
October 21, 2026 08:27
d4f1ea9 to
065e886
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
hugo.toml: replaced thebanner_flag/announcement_bannerbooleans with a[params.announcement]table holdingtext,url,link_text,startandend(ISO dates),preceded by a comment explaining usage. The current values are the 2026 conference text with
end = "2026-10-01", so nothing renders until someone sets a future window.layouts/partials/announcement-active.htmlreturnstrueonly when the build dateis within
[start, end](both inclusive;endis treated as the end of that day). It returnsfalsewhentext,startorendare missing.layouts/partials/announcement-banner.htmlnow renderstext, andurl+link_text(default"Learn more") when a URL is set, instead of hard-coded conference copy. It also checks the active
partial itself, so it is safe to include from anywhere.
layouts/partials/navbar.htmlincludes the banner via the new active check.layouts/shortcodes/blocks/section.htmlusedbanner_flagto decide whether to add a 50px topmargin on the first section; it now uses the same active check so the margin fallback still works.
Why
Plan item A3: the banner text was hard-coded in a template and toggled by config flags someone had to
remember to switch off, which is why the site was still thanking people for attending a past
conference. A config-driven banner with a date window expires on its own.
Acceptance criteria
[params.announcement]withtext,url,link_text,start,end.[start, end]. Verified by building once withend = "2026-10-12"(today) — banner present onindex.html— and once withend = "2026-10-01"— banner absent and the 50px margin fallback applied.banner_flag/announcement_bannerflags removed (no remaining references in layouts).next deploy, not at midnight. The comment in
hugo.tomlsays so.Translated pages affected
none
Checks run
"outside window" configurations.
grepof generatedindex.htmlforannouncement-bannerin both states as described above.Disclosure
Prepared with Claude (Anthropic); the author reviewed and edited all content.
Generated by Claude Code