Conversation
ShadowApex
requested changes
Sep 21, 2026
… torn down on_composite_device_stopped() previously just dropped each target's TargetDeviceClient handle instead of calling stop() on it, so the target task exited via a channel-disconnect error path that skipped implementation.stop()/destroy(), that leaked the uhid virtual device on every composite device teardown.
pastaq
force-pushed
the
pastaq/target_teardown
branch
from
September 29, 2026 01:54
369e850 to
6104a96
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
on_composite_device_stopped() previously just dropped each target's TargetDeviceClient handle instead of calling stop() on it, so the target task exited via a channel-disconnect error path that skipped implementation.stop()/destroy(), that leaked the uhid virtual device on every composite device teardown.
closes #317