Conversation
Contributor
|
Please just put |
Attach the existing hidraw haptics interface for the AYANEO Pocket S2 composite profile (4001:0428, interface 0). Assisted-by: LLM
mydanyi
force-pushed
the
feat/ayaneo-pocket-s2-hidraw
branch
from
September 21, 2026 15:52
16a3ad7 to
ddbd129
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AYANEO Pocket S2 profile already matches its evdev controller, but it does not declare the controller's hidraw haptics interface. As a result, the input path is available while the InputPlumber haptics source is not attached for the device.
Add the existing upstream hidraw source format used by
50-ayaneo_pocket_ds.yaml, selecting the Pocket S2 interface with vendor0x4001, product0x0428, and interface0. This is a six-line configuration-only change; controller targets and input mappings are unchanged.This follows the device profile introduced by #627. It is separate from #729: that PR covers generic/driver rumble behavior, while this change adds the missing Pocket S2 source declaration so the existing haptics path can be discovered.
Validation:
cargo test config::config_test::check_autostart_rules -- --exact --show-outputin the project Docker image: passed (1 test).git diff --check: passed.AI disclosure: CodeBuddy DeepSeek V4.1 Flash drafted this YAML-only addition. Codex independently reviewed the upstream profiles, checked for overlapping upstream work, and ran the configuration test.