Skip to content

Advance routine setup repairs automatically - #285

Merged
Staphylococcus merged 2 commits into
devfrom
codex/284-automatic-setup
Oct 4, 2026
Merged

Staphylococcus merged 2 commits into
devfrom
codex/284-automatic-setup

Conversation

@Staphylococcus

@Staphylococcus Staphylococcus commented Oct 4, 2026 •

Copy link
Copy Markdown
Owner

Summary

Fixes #284.

Starting setup now approves routine installation/repair work for the shared flow. GUI and CLI advance through remaining services and Plasma work automatically, skipping verified or inapplicable requirements.

  • Handle setup completion before the modal's opening frames; queued dismissal is cancelled if setup reopens.
  • Preserve the existing setup splash CTA and modal. Opening the ordinary UI or reading assessments never starts repairs.
  • Pause for TV input/approval, native authorization when needed, explicit build-dependency consent, and failed/blocked work. Retain flow-scoped authorization reuse and explicit retry.
  • Keep failed/blocked post-step verification visible instead of silently probing past it.
  • Propagate CLI progress/output errors before another repair starts, while allowing a noncancelable current mutation to finish.
  • Preserve cancellation gates, whole-flow exclusion, saved settings, and final verification: the GUI still waits for fresh daemon confirmation; CLI completion remains locally verified.

This changes progression, not step presentation or installation requirements.

Validation

  • cargo test --locked -p lg-buddy: all tests pass, including 1,426 library tests and 155 Cucumber scenarios (1,988 steps); one existing hardware test is ignored.
  • cargo clippy --workspace --all-targets --all-features -- -D warnings.
  • Display-backed GTK/controller suite on Nix and Ubuntu 24.04 / libadwaita 1.5; 20 consecutive Ubuntu runs pass, including early dismissal and reopening regressions.
  • Real CLI smoke via scripts/test-setup-cli.py, with loopback TV and isolated runtime.
  • Regression coverage for output failures during pairing and services, safe/noncancelable work, failed/blocked verification, explicit retry, dependency consent, stale actions, and frontend progression.
  • git diff --check.

TV, service, and authorization tests use isolated fixtures. Live hardware and a real native authorization dialog were not exercised.

Relates to #275 and #267.

@Staphylococcus Staphylococcus added this to the v1.10.0 milestone Oct 4, 2026
@Staphylococcus
Staphylococcus merged commit 9e741e0 into dev Oct 4, 2026
14 checks passed
@Staphylococcus
Staphylococcus deleted the codex/284-automatic-setup branch October 4, 2026 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant