Require flock for KWin setup and isolate authorization tests - #296
Closed
Staphylococcus wants to merge 3 commits into
Closed
Staphylococcus wants to merge 3 commits into
Staphylococcus wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
KWin setup and removal use a nonblocking file lock, but
flockwas an implicit executable dependency. That also made the authorization fixture fail in pure build environments and obscured the first failure with a second panic during child cleanup.util-linuxautomatically when/usr/bin/flockis absent, verify the executable, and stop before installing LG Buddy if it cannot be provided.flock -n 9call substitutable with a Nix store path.libc::flock, and make child fixture cleanup safe on failure.Scope
CONTRIBUTING.mdand the relevant docs linked there.User-Visible Behavior
The installer treats
flockas required for KWin setup. On apt, dnf, and pacman systems it installsutil-linuxwithout an optional-dependency prompt, verifies/usr/bin/flock, and stops before application installation if the dependency remains unavailable. Direct KWin setup reports a clear failure ifflockis missing.Validation
RUST_TEST_THREADS=1 cargo test --locked --offline -p lg-buddy --quiet: passed (1,463 library tests, 1 ignored; 155 Cucumber scenarios; integration targets).flock.util-linuxinstallation, plus an isolated PATH with the system executable present.flockabsent fromPATH.bash -n, scopedrustfmt --check, andgit diff --checkpassed.Text file busyin the unrelated GUI launcher test; the serial full run passed. The KWin shell smoke also fails at its existing provision assertion on this NixOS host in both the base and changed checkouts; the focused new lock diagnostic passed.Related Issue
None.