Repository navigation
Fix grunt build rebundling existing dist via browser field - #971
Merged
Merged
Conversation
The package.json browser mapping for ./lib/index points browserify at dist/jszip.min.js, so grunt build inlined the existing bundle instead of walking lib/. Temporarily remove that mapping during the build and restore package.json afterward. Signed-off-by: Jon Koops <jonkoops@gmail.com>
Stuk
approved these changes
Sep 8, 2026
jonkoops
added a commit
that referenced
this pull request
Sep 8, 2026
Release preparation for 3.10.2 - Fix cross-realm binary type detection in `getTypeOf`. Fixes [#759](#759) (see [#578](#578)) - Add missing types for `JSZip.defaults`. Fixes [#690](#690) (see [#927](#927)) - Fix Blob support in Node.js 18 and up. Fixes [#941](#941) (see [#955](#955)) - Fix grunt build rebundling existing dist via browser field (see [#971](#971)) - Move all continuous integration to GitHub Actions (see [#942](#942)) - Upgrade Playwright to the latest version (see [#940](#940)) - Create FUNDING.yml Signed-off-by: Jon Koops <jonkoops@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
grunt buildruns browserify onlib/index.js, butpackage.jsonmaps./lib/indexto./dist/jszip.min.js. Browserify followed that mapping and rebundled the existing dist, so changes underlib/never reacheddist/jszip.js.That showed up in CI as failing browser tests for source-only fixes. Node tests import
lib/directly, so they passed. Browser tests loaddist/jszip.js, andnpm run test-browserrunsgrunt buildfirst. Because the rebuild never picked uplib/changes, the browser suite was still exercising the old bundle.This change temporarily removes that mapping during the build and restores
package.jsonafterward. The release docs no longer describe doing that manually.