Inherit parent folder date when no file date is set - #975
Merged
Conversation
When a file is added without a { date } option, use the parent folder's
date if that folder already exists. A { date } on the file applies only
to that file and does not change the folder.
Signed-off-by: Jon Koops <jonkoops@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #610. Files added without a
{ date }option now pick up the parent folder's date when that folder is already in the archive, instead of each entry getting its ownnew Date(). Files added to an existing folder now share its date instead of each getting a fresh timestamp.Setting
{ date }on a file still only affects that file, not the folder.Generating the same archive twice can still produce different bytes if the run happens at a different time (#609). Fixing that needs a way to set one shared date when the zip is generated, not only when each entry is added.