Repository navigation
Conversation
Contributor
Author
|
hey @dnut Can I get a quick review please |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1742
Problem
sol_memcmp_translated both input slices, then translated the mutable result pointer, and only afterwards read the inputs:Under direct_mapping + VASA (SIMD-0460), the mutable translation can invoke the access-violation handler, which calls account.resize — reallocating and freeing the old backing
Fix
Compute the comparison into a plain i32 while both inputs are still valid, then translate the mutable result and write the value like agave
Changes
shared/vm/syscalls/memops.zig— move the comparison above the result translation; write the precomputed value.