Repository navigation
Clear animation overlay on transform spell end - #1013
Merged
Merged
Conversation
Try
reviewed
Oct 10, 2026
| closeWeapon(true); | ||
|
|
||
| // invalidate tallent overlays | ||
| visual.clearOverlays(); |
Owner
There was a problem hiding this comment.
should it be part of Npc::setVisual rather? setVisual already handles remapping of 'tallent'-overlays and might as well clear overlays upfront
thokkat
force-pushed
the
transform-spell
branch
from
October 11, 2026 18:29
995b00e to
3270291
Compare
Collaborator
Author
|
Done. |
Owner
|
@thokkat |
Collaborator
Author
|
Looks good for merge. |
Owner
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Monster Overlays aren't cleared if transformed back to human. Found in save from #984.
To reproduce transform to firewaran and back. Use forward jump attack in fistmode.