Repository navigation
Fix scroll-padding-top not reaching live site (style.css/scss collision) - #2062
Merged
Merged
Conversation
PR USRSE#2026 added assets/css/style.scss to set scroll-padding-top, but the repo already has a hand-maintained assets/css/style.css that compiles to the same output path. Jekyll's production build was serving the static style.css and silently dropping the Sass-compiled file, so the new rule never reached us-rse.org even though the PR merged and Pages rebuilt successfully. Move the rule directly into the static style.css and remove the now unnecessary style.scss. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
1 of 5 tasks
Member
Author
2 tasks done
exoticDFT
approved these changes
Sep 30, 2026
exoticDFT
left a comment
Member
There was a problem hiding this comment.
Looks good to me. The offset is working for a few pages I checked. Also, seems to work well enough for places where anchors have been manually added.
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1483
Summary
assets/css/style.scssto setscroll-padding-topso in-page anchor jumps aren't hidden behind the fixed navbar. That merged cleanly and GitHub Pages rebuilt successfully, but the site already has a hand-maintained, statically-committedassets/css/style.cssthat Jekyll compiles/copies to the same output path (/assets/css/style.css).style.css(12,262 lines of vendored/custom CSS) wins over the Sass-compiledstyle.scss, so the new rule silently never reached us-rse.org — no build error, just a destination-path collision.scroll-padding-toprule directly intoassets/css/style.css(alongside the other hand-added custom rules at the end of the file) and removes the now-unnecessarystyle.scss.Verified with a local
bundle exec jekyll build: previously the compiled output only contained ~10 lines (the Sass file, sincesite.themeisn't set the@importpulled in nothing); now the full 12,262-line stylesheet is emitted withscroll-padding-top: 3.25rem;included.Test plan
bundle exec jekyll buildsucceedsassets/css/style.csscontains the full existing stylesheet plusscroll-padding-top: 3.25rem;.scssfile remains to collide with the static.cssat the same destination path🤖 Generated with Claude Code