Repository navigation
ci: use the repository Rust toolchain in workflows - #846
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI overrides
rust-toolchain.tomlwith the movingstablechannel. On October 1 that selected Rust 1.99.0 and failed Clippy onasync_trait-generateddouble_must_usewarnings, while the repository-pinned Rust 1.94.0 passes the same strict workspace check.Use
rustup toolchain install --profile minimalwithout a channel so the test, release, npm-publish, and benchmark workflows install the toolchain selected by the repository. Keep the explicit Clippy/rustfmt components and existing cross-compilation target setup. This also removes the benchmark workflow's nightly override; the benchmarks use Criterion and have no nightly feature gates.Validation on macOS with the repository's Rust 1.94.0:
cargo clippy --offline --locked --all -- -D warningspassed.cargo fmt --all -- --checkpassed.rust-toolchain.toml; selection also resolves correctly fromhelios-ts.git diff --checkpassed.The separate live RPC sync failure is outside this change. Linux CI and release builds have not been run locally.