Repository navigation
fix(opstack): reject short decompressed gossip commitments - #866
Open
ninglinLiu wants to merge 1 commit into
Open
ninglinLiu wants to merge 1 commit into
ninglinLiu wants to merge 1 commit into
Conversation
SequencerCommitment::new sliced `[..65]` before checking length, so a short decompressed gossip payload panicked. With panic=abort that takes down the opstack server. Return an error instead so BlockHandler can Reject. Fixes a16z#850 This PR was prepared with AI assistance and reviewed/tested by the author.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SequencerCommitment::newsliced&decompressed[..65]before checking length. A gossip message that decompresses to fewer than 65 bytes panicked; withpanic = \"abort\"that stops the opstack server.Return an
eyreerror instead soBlockHandler::handlecanRejectthe message.Fixes
Fixes #850
Test plan
cargo test -p helios-opstack sequencer_commitment_rejects_short— new unit test passesThis PR was prepared with AI assistance and reviewed/tested by the author.