Skip to content

fix(bench): send a User-Agent when ingest downloads results #2321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0xAndoroid merged 1 commit into from
Nov 6, 2026
Merged

fix(bench): send a User-Agent when ingest downloads results #2321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion scripts/bench/ingest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ def download(url, limit, *, authenticated=False):
parsed = urlsplit(url)
if parsed.scheme != 'https' or parsed.username or parsed.password or not parsed.hostname:
raise ValueError('download must use credential-free HTTPS')
headers = {'Accept': 'application/vnd.github+json'}
headers = {'Accept': 'application/vnd.github+json',
'User-Agent': 'jolt-e2e-ingest/1 (+https://github.com/a16z/jolt)'}
if authenticated:
if parsed.hostname != 'api.github.com':
raise ValueError('artifact authentication is limited to GitHub')
Expand Down
15 changes: 15 additions & 0 deletions scripts/tests/test_e2e_ingest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,21 @@ def test_a_finalized_missing_target_result_is_valid_partial_data_for_each_tier(s
self.assertEqual(checked[0]['builds'], [])
self.assertEqual(ingest.check_result('123-1', checked, 1, 'failed')['conclusion'], 'failure')

def test_download_sends_descriptive_user_agent(self):
for url, authenticated in [('https://fixture.invalid/result.zip', False),
('https://api.github.com/repos/a16z/jolt/actions/artifacts/42/zip', True)]:
with self.subTest(url=url), patch.dict(os.environ, GH_TOKEN='fixture-token'), \
patch.object(ingest.urllib.request, 'build_opener') as opener:
opener.return_value.open.return_value = io.BytesIO(b'owned result')
self.assertEqual(ingest.download(url, 100, authenticated=authenticated), b'owned result')
request = opener.return_value.open.call_args.args[0]
self.assertEqual(request.get_header('User-agent'),
'jolt-e2e-ingest/1 (+https://github.com/a16z/jolt)')
redirected = ingest.DownloadRedirect().redirect_request(request, None, 302, 'Found', {},
'https://storage.invalid/result.zip')
self.assertEqual(redirected.get_header('User-agent'), request.get_header('User-agent'))
self.assertFalse(redirected.has_header('Authorization'))

def test_untrusted_zip_paths_and_download_caps_are_enforced(self):
self.assertEqual(ingest.result_files(zipped({'builds/fixture/build.log': b'owned log'})),
{'builds/fixture/build.log': b'owned log'})
Expand Down
Loading