Repository navigation
Conversation
|
@defidough is attempting to deploy a commit to the Aave Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General Changes
aria-labels to 10 icon-onlyIconButtons that screen readers announced as just "button": modal close, clear amount, clear search, mobile search toggle, info tooltip trigger, market favourite star, bridge network switch, migration market menu, and the two explorer links (token contract, bridge tx).DarkTooltip, which looks like it names them but doesn't: it wrapstitlein aBox, and MUI only appliestitleasaria-labelwhen it's a string. They now get the tooltip text as their label.TextWithTooltipgets an optionaliconLabelprop (default "More information"), so callers that render a warning icon can name it.IconButtonhas no accessible name (a plain MUITooltipwith a stringtitlecounts, since MUI applies it asaria-label;DarkTooltipdoes not).pnpm i18n.Developer Notes
Swap input controls are intentionally untouched. They're tracked in #3100, and the guard lists their exact
file:lineinKNOWN_UNLABELLED, so whoever fixes #3100 removes those entries, and a new unlabelled button in those files still fails. The guard is a static TypeScript-AST check rather than a render test because lingui macros aren't compiled under the jest transformer. No visual changes.