Repository navigation
Keep read tags when aligning reads and warn when the polyA tag is missing - #437
Open
andrewprzh wants to merge 1 commit into
Open
andrewprzh wants to merge 1 commit into
andrewprzh wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #433 / #429.
--polya_trimmed tag:pthad no effect when IsoQuant aligned the reads itself: minimap2 ran without-yandsamtools fastqwithout-T, so Dorado'spt:inever reached the BAM, and IsoQuant fell back to sequence-based detection without saying so.Changes
--polya_trimmed. This lets a BAM from an earlier run be reused with tag-based options without realigning, which takes longer than the rest of the pipeline.--unmapped_bam):samtools fastq -T <tags>|minimap2 -y. The tags are collected from the first 1000 reads.--fastq): when the header comments of the first 1000 reads are all tab-separated SAM tags (as in Dorado--emit-fastqoutput),samtools import -T|samtools fastq/fasta -T|minimap2 -y. Other files are passed to minimap2 directly, as before. FASTA stays FASTA, so no fake qualities are added.ts:iwould clash with minimap2'sts:A.RG/PGare not copied either, because the header lines they refer to are not carried over.run_piped_commands, with the same error messages and exit codes.--polya_trimmed tag:X, IsoQuant warns when none of the first 1000 primary alignments of a BAM carry X. The warning explains how to fix it:--clean_startfor alignments cached from earlier runs, orsamtools fastq -T | minimap2 -ywhen aligning yourself.docs/cmd.md(the tag must be present in aligned reads), a new "Read tags" section indocs/input.md,changelog.md.Notes
MM/ML) are kept when present, which can make the BAM noticeably larger.import -T; tested with 1.13.Testing
isoquant_tests/test_read_tags.py. They have not been run locally yet.chr9.4M.ptreached all alignments in each case, andts:i/RGwere dropped. The warning fires onchr9.4M.ont.sim.polya.bam, which has nopttag, and stays silent on the tagged output.🤖 Generated with Claude Code