Skip to content

[imaging_uploader] Fix outdated SQL query in TestPlan after CandID to CandidateID refactor - #11180

Merged
CamilleBeau merged 1 commit into
aces:27.0-releasefrom
HachemJ:FixTestPlanSQLcommandAssociatedToCandidateIDchange
Sep 14, 2026
Merged

CamilleBeau merged 1 commit into
aces:27.0-releasefrom
HachemJ:FixTestPlanSQLcommandAssociatedToCandidateIDchange

Conversation

@HachemJ

@HachemJ HachemJ commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Brief summary of changes

This PR fixes an outdated SQL query in the TestPlan.md of the imaging_uploader module that was missed during the CandID to CandidateID refactor and discovered while upgrading imaging_uploader to version 27 during the CBIGR upgrade.

Testing instructions (if applicable)

  1. Run the original query using a valid CandID for X (e.g. 947103) and Visit_label for Y (e.g. 'V6'). It should return an Unknown column 'CandID' error.
  2. Try the updated query using the same X and Y values and confirm that the corresponding session is successfully set to inactive (Active = 'N').

@github-actions github-actions Bot added the Module: imaging_uploader PR or issue related to imaging_uploader module label Aug 24, 2026

@MaximeBICMTL MaximeBICMTL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new query looks correct!

The test failure seems unrelated to that PR, it is in a file not touched by it.

@CamilleBeau
CamilleBeau merged commit 936aedd into aces:27.0-release Sep 14, 2026
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Module: imaging_uploader PR or issue related to imaging_uploader module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants