Repository navigation
[login] Allow multiple projects on account requests - #11182
Montekkundan wants to merge 3 commits into
Conversation
|
Functionality wise, the PR looks good. I will approve it once the translation file cleanup is done. The 'Project' label consistently appears in the singular form during my testing, despite the 'count: 2' parameter. This reminded me of a similar issue I encountered while working on the Biobank module, where Henri left the comment below #10801 (review). In that case, the fix was to revert to using the standalone 'Containers' key. We don’t currently have an equivalent standalone 'Projects' key here, so it may be worth looking into why the pluralization isn’t being applied correctly. This isn’t blocking the PR from my side, and I’ll approve it once the translation cleanup is done. For future reference, I would also suggest adding a regression check to the testing instructions to confirm that the existing single project workflow still works when only one project is selected. I tested that case as well and it worked as expected, I tested that case as well and it worked as expected. Thanks |
|
|
||
| msgid "Choose your project:" | ||
| msgstr "选择您的项目:" | ||
| msgid "Projects" |
There was a problem hiding this comment.
@HachemJ dug into the problem a little more and the problem is that the English locale doesn't have a msgid_plural for "Projects" despite the loris.pot saying it should have a plural form.
I think the solution here is:
- Go back to the "count: 99" to avoid needing to retranslate for every language
- Add msgid_plural to
locale/en/LC_MESSAGES/loris.poso that it correctly picks up the plural
There was a problem hiding this comment.
@driusan thank you for the clarification. @Montekkundan can you please revert your last commit and fix the rest as instructed in the comment above? Thank you!
Note: Please assign this PR back to me so I can test it again when you are done.
Brief summary of changes
Testing instructions
http://localhost:8081/and click Request Account.user_project_rel.Link(s) to related issue(s)