Log Git initialization failures before REST fallback - #2560
Open
mameikagou wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes Git initialization failures visible by logging the underlying createCommandManager error message before falling back to the REST-based download path, and adds a regression test to ensure the diagnostic is emitted while preserving existing fallback behavior.
Changes:
- Log a clear info-level message when
getGitCommandManagerfails to initialize the CommandManager, including the error message. - Add a Jest regression test covering the “Git init fails → log reason → REST fallback still happens” behavior.
- Rebuild
dist/index.jsto reflect the source change in the published action bundle.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/git-source-provider.ts |
Logs the Git CommandManager initialization failure message before returning undefined to trigger REST fallback. |
__test__/git-source-provider.test.ts |
Adds a regression test asserting the info log is emitted and REST download fallback still occurs. |
dist/index.js |
Updates the bundled output to include the new failure log behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
De-ASI-INTERFACE
approved these changes
Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dist/index.jsThis makes version and sparse-checkout failures visible without changing the current LFS or REST fallback semantics.
Closes #2435
Testing
npm test -- --runInBandnpm run format-checknpm run lintnpm run build