[Site Redesign] Logo-ticker Auto-roll with Play/Pause - #6736
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
|
|
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
| function parseAuthoring(el) { | ||
| const rows = [...el.children]; | ||
| const logos = [...rows[0]?.querySelectorAll('span.icon') ?? []]; | ||
| const [trackLabel = '', playLabel = 'Play logos', pauseLabel = 'Pause logos'] = (rows[1]?.textContent ?? '').split('||').map((s) => s.trim()); |
There was a problem hiding this comment.
Could these strings be defined via placeholders instead? Or is GWP already aware of this new authoring pattern?
There was a problem hiding this comment.
waiting for GWP to confirm if they will take this update, but I saw that the feds placeholders sheet isn't really actively used? And putting it in a consumer's sheet feels tricky as this lives in Milo and shared by both cc and dc, so I thought that carrying the strings inside the block feels more self-contained and easier for localization. But maybe there's a separate sheet I can use? Is there another milo placeholders that will be loaded for everyone? Thanks @overmyheadandbody !
9d77e51 to
d2df97b
Compare
|
Reminder to set the |
dariiarudenko2023-ops
left a comment
dariiarudenko2023-ops
left a comment
There was a problem hiding this comment.
QA-verified. More details in https://jira.corp.adobe.com/browse/MWPW-198910
GitHub Actions
Active
GitHub Actions
Active
This branch was successfully deployed
5 participants
Resolves: https://jira.corp.adobe.com/browse/MWPW-198910
Test URLs:
2 other pages logo-ticker is used: