[Release] Stage to Main - #6750
Merged
Merged
Conversation
* Initial checkin. Placeholder logic. * Added consent check. Changed list to tooltip. * Warning message WIP. * Refactor manifest status checks to improve error handling and messaging * Remove warning for missing manifest-changes-offers value in getManifestStatus function * Rename checkManifestConsent to checkPromoRange for clarity and update references * Fix fetchData check and enhance manifest data validation in getManifestConfig function * Move error handling for malformed manifests in getManifestStatus function since malformed manifests negate the need for any other checks. * Update error message for malformed manifest in buildManifestCard test * Enhance error handling for malformed manifests by including error details in buildMalformedManifestEntry and updating getManifestStatus to reflect specific errors. * Refactor getManifestConfig to streamline data fetching and error handling * Update error message for malformed manifest in buildManifestCard test * Add error field to manifestErrors for broken manifest in buildManifestCard test * restore ability to have no info tab for now * Add error details to manifestErrors for broken and empty manifests * Add geoDisabled flag to manifestConfig when geoRestriction is not met * Rename geoRestriction to countryRestriction across the codebase for clarity and consistency * Refactor consent handling and country restrictions in MEP - Renamed geoRestriction to countryRestriction for clarity. - Introduced consentType to replace mktgAction in various functions and components. - Added logic to handle consent requirements, including consentNotSpecified and consentEnabled flags. - Updated manifest error handling to include consent-related errors. - Modified tests to reflect changes in consent handling and ensure proper functionality. - Enhanced analytics tracking based on consent requirements. * Update consentState keys in tests for clarity and accuracy * Update manifest status label from 'Ineligible' to 'Disabled' * Remove unused parameter 'mktgAction' from buildManifestEntry function * Changed warning color from yellow to gray. * Add disabledPromo property to activity and manifest handling * Refactor geo restriction and manifest serving logic to support async operations * Enhance geo restriction logic to utilize countryIPPromise if available * Update consent message for clarity in manifest status * Add consent type checks for non-personalized and personalized offers in manifest status * Revert "Enhance geo restriction logic to utilize countryIPPromise if available" This reverts commit e2f1341. because the issue is fixed in #6611 instead * Fix: Remove redundant fallback in persData assignment in getManifestConfig function * Merge branch 'mep-disabled-manifests-v2' into mepcountrytogeo * Merge branch 'mepcountrytogeo' into mepconsent * Fix: Enhance persData assignment to handle array data in getManifestConfig function * Fix unresolved merge conflict markers left in stage merge commit The merge of stage into mepconsent (789740e) was committed while these files still contained literal conflict markers, breaking JS parsing. Resolves them by keeping mepconsent's consentType model (over stage's simpler mktgAction), dropping the dead mepgeolocation flag superseded by #6611, and fixing a stale test that asserted against the no-longer-read akamaiCode field instead of countryIP. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * Normalize consent type handling to be case-insensitive and update tests accordingly * fix: enforce mep param > country > consent variant override priority Reorder setCountryEnabled() before setConsentEnabled() in getManifestConfig() and short-circuit the non-personalized offer test substitution when countryEnabled is false, so pickNonPznVariant() is never invoked for geo-ineligible users. Prevents a real variant from being allocated and persisted to localStorage before geo eligibility is evaluated. Add integration test covering non-personalized offer test + performance consent off + non-matching country, asserting variantOverride[path] === 'Default' and localStorage['mep-'] is not written. --------- Co-authored-by: AdobeLinhart <dlinhart@adobe.com> Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
* TypeKit load strategy challenger * [MWPW-198891] Load brand fonts quicker
No upgrade block on the page makes querySelector return null; the next getAttribute call threw, rejecting getCheckoutAction's Promise.all and discarding the CRM modal action, so logged-in non-Acrobat users got a dead CTA. Return early when there is no upgrade offer.
* support for a launch url override via the launch-url metadata property * updates based on feedback * remove whitespace
Contributor
Author
|
Testing can start @adobecom/bacom-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot @adobecom/express-sot @adobecom/homepage-sot @adobecom/miq-sot @adobecom/blog-sot |
Contributor
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
|
Contributor
|
SNOW Change Request Transaction ID: 0000019c1eec85a3-22a9112e |
* MWPW-203780: Support carousel-c2 with two slides * MWPW-203780: Address review feedback on carousel-c2 two-slide support - Replace per-clone MutationObserver with a single MILO_EVENTS.DEFERRED listener; refreshCloneBackgrounds now rebuilds both padded hint clones and permanent loop-ring clones once their source background decorates - Move loading=eager into createSlideClone so rebuilt clones keep it - Guard against fewer than two slides and clear the block instead of throwing / leaving raw config rows in the DOM - Extract SLIDES_TO_SHOW constant for the pad/ring count - Add tests for ring-clone rebuild and the single-slide guard Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * Avoid twice adding attribute to the clone slide img. --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
…he default (#6699) * Add within-firewall auth bypass and make mep-next the default Lets employees on the corp network skip AEM Sidekick sign-in for MEP overlay access via a DNS-only reachability check against an internal host, with a "Check again" link on the login card to re-run the check. Also flips the mepnext gate so mep-next loads by default, with ?mepnext=off retained as the legacy preview.js escape hatch. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * Add tests for isWithinFirewall and update onSidekickAuth to await firewall checks * Add fetch stub rejection for isWithinFirewall() to test timeout Sidekick-auth path * make unit test more strict to pass security check * Update logged out button css. * fix(mep): avoid firewall delay blocking Sidekick auth add timeout to corp firewall reachability probe initialize Sidekick auth listeners immediately instead of waiting on the probe allow a successful firewall check to grant access and stop further auth checks update unit tests for concurrent firewall auth behavior and override semantics * fix(auth): enhance Sidekick auth handling and improve firewall integration * fix: update isMepNextOverlay logic for better URL parameter handling * fix: avoid duplicate MEP overlay initialization --------- Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com> Co-authored-by: AdobeLinhart <dlinhart@adobe.com>
…t Spaces Frictionless pages (#6746) fix Co-authored-by: Ketaki Deshwandikar <ketaki@youremail.com>
…6623) * Add MEP Next spoof-country-ip and "Manifest Parameters" preview toggle - Pair Target's mboxOverride.browserIp with akamaiLocale in the MEP spoofers via applyGeoSpoof (spoof-country-ip.js + test). - Add a Toggle-card switch that omits the `mep` param from the preview URL so the previewed page loads with no manifest parameters applied. Wired into setPreviewButton; covered by two overlay-logic tests. * Fix Spoof Geo card collapsing when radio buttons are clicked The card collapse handler matched any `svg` inside a `.mep-card`, so clicking a Spoof Geo radio-row icon (an svg in the card body) bubbled up and toggled the card. Scope the trigger to `.mep-card h1 svg` so only the header chevron collapses the card. Adds a regression test. * Persist Manifest Parameters toggle across preview reloads Store the toggle state in sessionStorage so it survives a preview reload but clears when the tab closes (avoids a sticky, forgotten "don't apply manifests" state across QA sessions). Restored in setDefaultValues and written from the drawer change handler. * MWPW-204279 [MEP] Keep bare mep param when manifest params excluded The Manifest Parameters toggle deleted the mep param entirely, which hides the MEP button in prod (utils gates the preview path on mepParam === ''). Keep a valueless mep param instead: the button still renders and no manifest parameters are applied. Serialize it as a bare `mep` (no trailing `=`).
hadobe
self-requested a review
September 17, 2026 22:00
hadobe
approved these changes
Sep 17, 2026
sigadamvenkata
approved these changes
Sep 18, 2026
Contributor
|
I saw error on this page, is that expected? https://www.stage.adobe.com/error-pages/404.html |
JackySun9
approved these changes
Sep 18, 2026
JackySun9
previously requested changes
Sep 18, 2026
JackySun9
left a comment
JackySun9
left a comment
Contributor
There was a problem hiding this comment.
hold on for this https://www.stage.adobe.com/error-pages/404.html
narcis-radu
dismissed
JackySun9’s stale review
September 21, 2026 08:16
Faulty code has been reverted. Dismissing Jacky's review.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
common base root URLs
Homepage : https://www.stage.adobe.com/
BACOM: https://business.stage.adobe.com/fr/
CC: https://www.stage.adobe.com/creativecloud.html
Blog: https://blog.stage.adobe.com/
Acrobat: https://www.stage.adobe.com/acrobat/online/sign-pdf.html
Milo: