Mwpw 204848 firefly unity showcase - #881
Conversation
…com/unity into MWPW-204848-firefly-unity-showcase
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
sanjayms01
left a comment
There was a problem hiding this comment.
Thanks for raising this PR!
Couple comments:
- Please remove all comments from the files. As much as they are helpful, we typically avoid adding comments to optimize on performance.
- Instead of calling
isFireflyRedesign()in your conditionals, maybe you can just add a class variable in the constructor that calls the function and then you can just refer to the class variable thereafter.
I also reviewed the test page and noticed few issues with the CSS. I have shared these in the ticket for your reference.
Please all pull the latest changes from stage when you get a chance so the PR is up to date.
…com/unity into MWPW-204848-firefly-unity-showcase
cd39ec3 to
bb1ae68
Compare
696de83 to
f1dc384
Compare
79d6aad to
6bcd5c7
Compare
|
Validated in branch. All looks fine. Done sanity on doodle pages as well. Complete E2E testing will be done on stage. |

Change Summary:
Resolves: MWPW-204848
Test URLs:
Screenshots:
