Repository navigation
fix: wrap individual RR syscalls for batch execution - #560
Draft
Solaris-star wants to merge 1 commit into
Draft
Solaris-star wants to merge 1 commit into
Solaris-star wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #504.
The LLM queue returns one syscall per
getMessage()call. The RR worker passed that object directly to_execute_batch_syscalls(), whose first iteration raisesTypeErrorbefore reaching the LLM adapter. This still reproduces on main at292d98f7.Wrap the queue item in a singleton list at the dispatch boundary. The batch helper and its existing multi-item API stay unchanged.
Tests
Added four cases covering an empty queue, one request, consecutive requests, and direct multi-item batch dispatch. The queue helper, scheduler, base scheduler, and
Syscallclass are real; the LLM executor is mocked.Queryannotation dependency. Ordinary pytest collection in the available environment is blocked by missingcerebrum; the full dependency installation, full suite, and Ollama/Qdrant integration tests were not run.No public API or configuration change, so no user documentation update is needed. Keeping this draft pending broader environment validation and maintainer review.