Repository navigation
Add lld - #178
Merged
Merged
Add lld#178
Conversation
Fix all tests to update expectations from fixture update - no hard coding
zuhdil
reviewed
Sep 23, 2026
| | Document | Low-Level Design — technical description | | ||
| | System | IGH Pipeline Portal | | ||
| | Companion document | `IGH-Pipeline-Portal-HLD.docx` (functional description) | | ||
| | Repositories | `igh-dashboard`, `igh-data-sync`, `igh-data-transform`, `igh-airflow`, `igh-dashboard-content` | |
Contributor
There was a problem hiding this comment.
It might be necessary to add a link to each repository because without it it might be difficult for readers to find them.
| file is written. The chain is wired with Airflow 3 **Assets**: a task that finishes with an | ||
| asset in its `outlets` emits an event, and a DAG with that asset in its `schedule` starts. | ||
| `igh-airflow/dags/igh_assets.py` declares one asset per database. Neither | ||
| `TriggerDagRunOperator` nor `ExternalTaskSensor` is used. Declaring the chain this way rather |
Contributor
There was a problem hiding this comment.
Mentioning things that aren't used doesn't add to the reader's understanding; it is simply contextual noise.
| ## 3. Container Diagram | ||
|
|
||
|  | ||
|
|
Contributor
There was a problem hiding this comment.
I don't think we need to explain the Airflow infrastructure. It's a third-party tool that we use as-is, and it can obscure our important components. I think Airflow can be described as a black box -much like Traefik, Redis, and Celery- that orchestrates our three DAGs.
| docker compose stop && docker compose up -d | ||
| ``` | ||
|
|
||
| Test deploys on every merge to `main`. Production deploys when a GitHub Release is published. |
Contributor
There was a problem hiding this comment.
More precisely, on every push to main, PR merge is a form of push.
zuhdil
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.