Repository navigation
[bug]: algoliasearch doesn't compile with Node 20 #1594
Description
Description
When compiling we get the following error:
node_modules/@algolia/client-common/dist/common.d.ts:43:20 - error TS2304: Cannot find name 'Storage'.
43 localStorage?: Storage | undefined;
~~~~~~~
Steps to reproduce:
- Run
mkdir algolia-test && cd algolia-test - Run
npx gts init - When you read
package.json does not exist. Generate:typey - Run
npm install algoliasearch - Run
npm install @types/node@20 - Add
import {algoliasearch} from 'algoliasearch';to the top of theindex.ts - Run
npm run compile
Client
All
Version
5.35.0
Relevant log output
npm run compile
> compile
> tsc
node_modules/@algolia/client-common/dist/common.d.ts:43:20 - error TS2304: Cannot find name 'Storage'.
43 localStorage?: Storage | undefined;
~~~~~~~
Found 1 error in node_modules/@algolia/client-common/dist/common.d.ts:43
Activity
Haroenv commentedon Aug 8, 2025
This isn't enough information, you have not provided what typescript settings you're using which cause this error. Please create a full reproduction first.
shortcuts commentedon Aug 8, 2025
it seems like it resolves to the browser build for some reason so should indeed be related to the tsconfig
IchordeDionysos commentedon Aug 26, 2025
@Haroenv if you follow the exact steps I provided you can see the exact typescript settings I am using!
IchordeDionysos commentedon Aug 26, 2025
tsconfig.json
{ "extends": "./node_modules/gts/tsconfig-google.json", "compilerOptions": { "rootDir": ".", "outDir": "build" }, "include": [ "src/**/*.ts", "test/**/*.ts" ] }tsconfig-google.json
{ "compilerOptions": { "allowUnreachableCode": false, "allowUnusedLabels": false, "composite": true, "forceConsistentCasingInFileNames": true, "lib": ["ES2023"], "module": "commonjs", "noEmitOnError": true, "noFallthroughCasesInSwitch": true, "noImplicitReturns": true, "pretty": true, "sourceMap": true, "stripInternal": true, "strict": true, "target": "ES2022" }, "exclude": ["node_modules"] }