Repository navigation
GH-54921: [C++][Python][ORC] Add batch iteration over selected stripes #54926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jiangxt2
wants to merge
9
commits into
apache:main
Choose a base branch
from
jiangxt2:orc-stripe-batch-reader
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+674
−1
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
6efd357
GH-54921: [C++][Python][ORC] Add batch iteration over selected stripes
jiangxt2 7315f4e
GH-54921: [Python][ORC] Keep batch tests independent of NumPy
jiangxt2 2784dce
GH-54921: [C++][Python][ORC] Merge main into batch reader branch
jiangxt2 949bf7b
GH-54921: [Python][ORC] Simplify batch tests and column selection
jiangxt2 ede98db
GH-54921: [C++][Python][ORC] Address stripe batch reader review
jiangxt2 ce1c804
GH-54921: [Python][ORC] Share column checks and simplify validation
jiangxt2 95b5182
GH-54921: [CI] Retrigger CI
jiangxt2 68cfeac
GH-54921: [C++][Python][ORC] Merge main to refresh CI
jiangxt2 426e855
GH-54921: [C++][Python][ORC] Bound batch allocation and simplify iter…
jiangxt2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preserving the row count is the right behaviour (it matches Parquet), but it makes
columns=[]mean different things across the API. On 26.0.1:while
iter_batches(columns=[])keeps the rows. The docs say column selection "followsread_stripe", andtest_iter_batches_projectionhas to special-case[]because of this.Should we apply the same short-circuit in
ReadBatchso all three agree?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing this out.
iter_batches(columns=[])preserves the row count, whileORCFile.read(columns=[])andread_stripe(i, columns=[])currently return zero rows. I clarified that the column selection syntax matchesread_stripe. Since #54921 proposes keeping the existing read APIs' behavior unchanged, would you be comfortable addressing their zero-column row counts in a separate follow-up?