CASSANDRA-21642 Consider the introduction of flush_compression CQL table parameter - #5100
Draft
smiklosovic wants to merge 3 commits into
Draft
CASSANDRA-21642 Consider the introduction of flush_compression CQL table parameter#5100smiklosovic wants to merge 3 commits into
smiklosovic wants to merge 3 commits into
Conversation
bbotella
reviewed
Sep 7, 2026
| if this_opt in ('read_repair'): | ||
| return [Hint('<\'none\'|\'blocking\'>')] | ||
| if this_opt == 'flush_compression': | ||
| return ["'auto'", "'none'", "'fast'", "'table'"] |
Contributor
There was a problem hiding this comment.
Do we want to hard code this on the parser.g?
| public boolean compatibleWith(ClusterMetadata metadata) | ||
| { | ||
| return metadata.directory.commonSerializationVersion.isAtLeast(Version.V0); | ||
| return metadata.directory.commonSerializationVersion.isAtLeast(attrs.minimumSerializationVersion()); |
| // entirely as the "compression" member field is provided outside the scope of this class. | ||
| // It may make sense in the future to refactor the ownership of the compression flag so that | ||
| // We can bypass the CompressedSequentialWriter in this case entirely. | ||
| case auto: |
Contributor
There was a problem hiding this comment.
Do we need a case for "fast"?
Contributor
Author
There was a problem hiding this comment.
yeah, I think we need that, also to be aligned with what is in yaml. fast is in this case and also in auto logic in resolveCompressionParams
patch by Stefan Miklosovic; reviewed by TBD for TBD
smiklosovic
force-pushed
the
CASSANDRA-21642
branch
from
September 8, 2026 10:30
0af47d1 to
655d953
Compare
smiklosovic
force-pushed
the
CASSANDRA-21642
branch
from
September 8, 2026 10:40
655d953 to
2fe3e5e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for sending a pull request! Here are some tips if you're new here:
Commit messages should follow the following format:
The Cassandra Jira