Repository navigation
[fix] Reconcile legacy-owned native resources and BE replica drift - #538
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Native DorisCluster Services and StatefulSets have non-controller owner references, so the default Owns handlers miss their resource events. A deleted FE Service can remain absent. Separately, a manually changed BE replica count can be hidden by an unchanged cached hash annotation.
Accept matching non-controller owners without changing existing resource metadata. In the native BE controller, verify the observed replica count after the existing hash and legacy-environment comparison. The shared comparator, CN autoscaling and DDC comparison paths remain unchanged.
Release note
Restore event-driven reconciliation of legacy-owned native Doris resources and correction of BE replica drift.
Check List (For Author)
Validation:
go test ./... -count=1with Kubernetes 1.31 envtest assets.go vet ./...; generated manifests/deepcopy check.Manual Kubernetes upgrade regression (master fix):
Check List (For Reviewer who merge this PR)